Skip to content

change: Add troubleshooting links to exceptions #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

change: Add troubleshooting links to exceptions #4844

merged 2 commits into from
Aug 21, 2024

Conversation

Aditi2424
Copy link
Contributor

@Aditi2424 Aditi2424 commented Aug 21, 2024

Issue #, if available:

Description of changes:

  1. Updated pydocs for methods to include section on what all exceptions can be thrown and when.
  2. Linked troubleshooting document in create/ update training, create processing and create/ update endpoint.
  3. Improved some exception messages thrown from the SDK.

Testing done: Installed tar file on studio and executed example notebooks.
Screenshot 2024-08-21 at 7 44 13 AM
Screenshot 2024-08-21 at 7 44 33 AM
Screenshot 2024-08-21 at 7 50 12 AM

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Aditi2424 Aditi2424 requested a review from a team as a code owner August 21, 2024 18:17
@Aditi2424 Aditi2424 requested a review from pintaoz-aws August 21, 2024 18:17
@Aditi2424 Aditi2424 merged commit e240518 into aws:master Aug 21, 2024
12 of 14 checks passed
@Aditi2424 Aditi2424 deleted the troubleshooting branch August 21, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants